Repository navigation
feat(crons): Add rufus-scheduler cron monitoring - #3110
Merged
Merged
Conversation
wedamija
force-pushed
the
danf/rufus-scheduler-crons
branch
from
October 15, 2026 18:57
bb10236 to
d9306dd
Compare
This was referenced Oct 16, 2026
wedamija
force-pushed
the
danf/rufus-scheduler-crons
branch
from
October 16, 2026 17:02
d9306dd to
75667e8
Compare
wedamija
marked this pull request as ready for review
October 16, 2026 23:59
sl0thentr0py
force-pushed
the
danf/rufus-scheduler-crons
branch
from
October 21, 2026 14:31
7320f2c to
8bebc37
Compare
sl0thentr0py
approved these changes
Oct 21, 2026
Opt-in via `config.enabled_patches << :rufus_scheduler`. Sends in_progress/ok/error check-ins for cron, every and interval jobs, with a monitor config for cron and fixed-interval every jobs, built with Sentry::Cron::FugitSchedule. Jobs run unmonitored when building the monitor fails. Method handlers are named after their owner and method, unnamed blocks are skipped with a log asking for name:, and long slugs keep their first 50 characters. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Method handlers were slugged by the class that defines the method, so subclasses sharing an inherited method, or classes sharing a mixin method, collided on one monitor. Co-Authored-By: Claude <noreply@anthropic.com>
Matches the sidekiq-cron and sidekiq-scheduler patches, so the patch still applies when rufus-scheduler is loaded after Sentry.init. Co-Authored-By: Claude <noreply@anthropic.com>
sl0thentr0py
force-pushed
the
danf/rufus-scheduler-crons
branch
from
October 21, 2026 15:55
8bebc37 to
e94ab09
Compare
Avoids the backtracking /-+\z/ regex that CodeQL flags, and strips every trailing dash left by truncation. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series that sends Crons monitor configs from Ruby schedulers. Check-ins for a monitor that does not exist yet are dropped, so today every monitor has to be created by hand with its schedule copied from the code. Sending the schedule lets Sentry create the monitor and keep it in sync.
This adds an opt-in patch for rufus-scheduler:
cronandeveryjobs send in-progress and ok/error check-ins, with the job's schedule as the monitor config.name:, or the handler's class or method. Unnamed blocks aren't monitored, andsentry_monitor: falseopts a job out.intervaljobs and schedules Sentry can't represent check in without a config. One-offinandatjobs aren't monitored.on_error.Stacked on #3141. The lockfile changes only add
rufus-scheduleras a dev dependency.Docs: getsentry/sentry-docs#19789